Vlanmgrd handling of portchannel does not exist more gracefully. #3367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and we try to add it vlan as member in kernel. Signed-off-by: Abhishek Dosi <[email protected]>
abdosi
changed the title
|
@yejianquan for viz. |
|
Hey @abdosi, looks like the code coverage check did not pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Fixes sonic-net/sonic-buildimage#20684
Why I did:
It is seen when doing
config reloadon multi-asic (multiple instances of swss/teamd) their might be race condition when teammrd might be getting SIGTERM and cleaning up the port-channel in kernel and vlanmgrd might be adding the port channel as member in kernel and this can cause the exception as this operation as being done in async.How I did:
To handle the failure gracefully if we get an exception when portchannel as vlan member in kernel we check if Portchannel exists and if not we just retry to minimize the risk of failure due to above race-condition.